Update 2.0.3, fix LoggerManagement currency problem #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
============================================
+ Coverage 34.69% 35.15% +0.46%
- Complexity 672 692 +20
============================================
Files 74 75 +1
Lines 5693 5746 +53
Branches 1094 1097 +3
============================================
+ Hits 1975 2020 +45
- Misses 3466 3470 +4
- Partials 252 256 +4
☔ View full report in Codecov by Sentry. |
HzjNeverStop
changed the title
|
Can codes simplify to if (!isSpaceILoggerFactoryExisted(spaceId)) {
synchronized (space) {
if (!isSpaceILoggerFactoryExisted(spaceId)) {
factory = createILoggerFactory(spaceId, space, spaceClassloader);
space.setAbstractLoggerSpaceFactory(factory);
}
}
}
factory = LOG_FACTORY_MAP.get(spaceId).getAbstractLoggerSpaceFactory();
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.